[ADD] Quality: Instructions quality check #5689
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Felicious
approved these changes
Sep 6, 2023
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
Hi @hojo-odoo !
This is a super solid doc-- clear and straightforward as usual! 😁 I just had suggestions for brevity and adding more context to a step (contradictory, I know 😅) These are just optional suggestions, so feel free to tag the next reviewer once you take a look!
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
16.0-quality-add-instructions-check-hojo
branch
from
84a17d9 to
3765edf
Compare
ksc-odoo
reviewed
Sep 18, 2023
Contributor
ksc-odoo
left a comment
ksc-odoo
left a comment
There was a problem hiding this comment.
hey @hojo-odoo -- great job on this doc. I only had a few, super-minor suggestions for you to look at, which mainly deal with adding some spacing to break up "longer" paragraphs. But, other than that, I think this doc looks good. Nicely done 👍
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/quality_control/instructions_check.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
16.0-quality-add-instructions-check-hojo
branch
from
3765edf to
e23feeb
Compare
Felicious
approved these changes
Oct 5, 2023
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
Hello @hojo-odoo! Just finished my second review of this doc :D
Thanks for re-requesting my review after making significant changes to this doc. I added a couple comments to add more context to the viewer about when you want to create quality alerts, and why an Instructions quality check could be set on certain operation types. These are all optional.
Great job writing this doc! It has clear and concise instructions with smooth UI navigation! 😊👍
content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
16.0-quality-add-instructions-check-hojo
branch
from
e23feeb to
c83999d
Compare
hojo-odoo
force-pushed
the
16.0-quality-add-instructions-check-hojo
branch
from
c83999d to
bbf73fb
Compare
hojo-odoo
force-pushed
the
16.0-quality-add-instructions-check-hojo
branch
2 times, most recently
from
15c3635 to
ca99cfd
Compare
StraubCreative
requested changes
Nov 13, 2023
Contributor
StraubCreative
left a comment
StraubCreative
left a comment
There was a problem hiding this comment.
hi @hojo-odoo
A couple quick changes below:
- format all Instructions check references
- remove the old/dup internal anchor in
quality_control_points.rst
After that we should be g2g
content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_management/quality_control_points.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
16.0-quality-add-instructions-check-hojo
branch
from
ca99cfd to
f3f8e46
Compare
Contributor
Author
|
@StraubCreative I've addressed your comments. |
robodoo
pushed a commit
that referenced
this pull request
Nov 13, 2023
closes #5689 Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
This was referenced Nov 13, 2023
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new doc detailing how to create and process Instructions quality checks.
NOTE: One of the checks is failing because the PR contains references to the "Quality checks" doc, which is not yet live. That doc should be live before this one, at which point the ref tags in this doc will work as intended.